Message

Reply | Reply all

Date Prev | Date Next | Thread Prev | Thread Next Date Index | Thread Index

From: cvs at opencores.org<cvs@o...>
Date: Thu Nov 29 16:14:44 CET 2007
Subject: [cvs-checkins] MODIFIED: jop ...
Date: 00/07/11 29:16:14

Modified: jop/java/tools/src/com/jopdesign/debug/jdwp SymbolTable.java
Log:
Fixed bug in the method ID assignment.

Created method to check if a method ID is valid or not.



Methods changed:

336: private int getMethodId(MethodInfo methodInfo)

341: public int getMethodStructPointer(String className, String methodSignature)





Methods created:

918: public boolean isValidMethodStructurePointer(int methodPointer)






Revision Changes Path
1.3 jop/java/tools/src/com/jopdesign/debug/jdwp/SymbolTable.java

http://www.opencores.org/cvsweb.shtml/jop/java/tools/src/com/jopdesign/debug/jdwp/SymbolTable.java.diff?r1=1.2&r2=1.3

(In the diff below, changes in quantity of whitespace are not shown.)

Index: SymbolTable.java
===================================================================
RCS file: /cvsroot/paulo/jop/java/tools/src/com/jopdesign/debug/jdwp/SymbolTable.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- SymbolTable.java 6 Nov 2007 04:48:08 -0000 1.2
+++ SymbolTable.java 29 Nov 2007 15:14:44 -0000 1.3
@@ -335,18 +335,18 @@

private int getMethodId(MethodInfo methodInfo)
{
- return methodInfo.getCodeAddress();
+ return MethodTable.getMethodId(methodInfo);
}

public int getMethodStructPointer(String className, String methodSignature)
{
- int methodId;
+ int methodStructPointer;
MethodInfo methodInfo;

methodInfo = getMethodInfo(className, methodSignature);
- methodId = methodInfo.getStructAddress();
+ methodStructPointer = methodInfo.getStructAddress();

- return methodId;
+ return methodStructPointer;
}

public int getMethodSizeInWords(String className, String methodSignature)
@@ -908,4 +908,23 @@
}
return classes;
}
+
+ /**
+ * Check if a method pointer is valid or not.
+ *
+ * @param methodPointer
+ * @return
+ */
+ public boolean isValidMethodStructurePointer(int methodPointer)
+ {
+ boolean isValid;
+ MethodInfo info;
+
+ // check if there is any method registered with this pointer.
+ // if it's not, then this is an invalid method pointer.
+ info = getMethodInfo(methodPointer);
+ isValid = (info != null);
+
+ return isValid;
+ }
}